The parent link (#122/#183) is meant to be the inverse of collection
membership, but only append() maintained it.
insert(), extend() and setitem() called setParent(owner.lock())
unconditionally. A scene collection has no owner drawable, so that
resolved to null -- and setParent(nullptr) also clears parent_scene. The
drawable landed in the scene's UI vector, rendered fine, and reported a
.parent of None.
The slice arms never touched the link at all. A slice-delete left the
removed child pointing at a parent that no longer contained it; a
slice-assign never parented the incoming items, nor unparented the ones
they displaced. A stale parent is a live weak_ptr to a frame the child
has left, and it is what get_global_position() walks.
Route every mutator through link_child()/unlink_child(), which are now
the single place that knows a scene parents via setParentScene() and a
drawable via setParent().
Three latent traps in the same functions, found while fixing this:
* collection[-1] on an EMPTY collection hung the engine forever:
`while (index < 0) index += size()` adds zero on every pass.
* getitem's `index > size() - 1` check underflowed to SIZE_MAX when
size() was 0, so the bounds check passed and it indexed an empty
vector.
* insert() and setitem() resolved the index before detaching the
incoming drawable from its old parent. If it was already a member of
the same collection, detaching erased it and shifted everything
after -- so an index validated against the old size could write past
the end. Slice-assign now builds its result as an independent vector
for the same reason.
closes #377
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| api | ||
| benchmarks | ||
| cookbook | ||
| demo | ||
| docs | ||
| fixtures | ||
| fuzz | ||
| geometry_demo | ||
| integration | ||
| notes | ||
| procgen_interactive | ||
| regression | ||
| snapshots | ||
| unit | ||
| vllm_demo | ||
| all_inputs.py | ||
| conftest.py | ||
| debug_viewport.py | ||
| gui.py | ||
| KNOWN_ISSUES.md | ||
| procgen_cave2_visualization.py | ||
| procgen_cave_visualization.py | ||
| pytest.ini | ||
| README.md | ||
| run_procgen_interactive.py | ||
| run_tests.py | ||
| shader_poc_test.py | ||
| shader_toggle_test.py | ||
| test_mcrogueface.py | ||
| wiki_api_verify.py | ||
| wiki_phase_d2_verify.py | ||
| wiki_phase_d3_verify.py | ||
| wiki_phase_d_verify.py | ||
| wiki_snippets_verify.py | ||
McRogueFace Test Suite
Automated tests for the McRogueFace game engine.
Directory Structure
tests/
├── unit/ # Unit tests for individual components (155+ tests)
├── integration/ # Integration tests for system interactions
├── regression/ # Bug regression tests (issue_XX_*.py)
├── benchmarks/ # Performance benchmarks
├── demo/ # Interactive demo system
│ ├── demo_main.py # Demo runner
│ └── screens/ # Per-feature demo screens
├── conftest.py # Pytest configuration and fixtures
├── pytest.ini # Pytest settings
├── run_tests.py # Standalone test runner
└── KNOWN_ISSUES.md # Test status and mcrfpy.step() documentation
Running Tests
With pytest (recommended)
# Run all tests
pytest tests/ -v
# Run specific directory
pytest tests/unit/ -v
# Run tests matching a pattern
pytest tests/ -k "bsp" -v
# Quick run with short timeout (some timeouts expected)
pytest tests/ -q --mcrf-timeout=5
# Full run with longer timeout
pytest tests/ -q --mcrf-timeout=30
# Stop on first failure
pytest tests/ -x
With run_tests.py
# Run all tests
python3 tests/run_tests.py
# Run specific category
python3 tests/run_tests.py unit
python3 tests/run_tests.py regression
# Verbose output
python3 tests/run_tests.py -v
# Quiet (no checksums)
python3 tests/run_tests.py -q
# Custom timeout
python3 tests/run_tests.py --timeout=30
Running individual tests
cd build
./mcrogueface --headless --exec ../tests/unit/some_test.py
Writing Tests
Test Pattern: Synchronous with mcrfpy.step()
Recommended: Use mcrfpy.step(t) to advance simulation time synchronously.
import mcrfpy
import sys
# Setup
scene = mcrfpy.Scene("test")
scene.activate()
# Create UI elements
frame = mcrfpy.Frame(pos=(100, 100), size=(50, 50))
scene.children.append(frame)
# Start animation
frame.animate("x", 500.0, 1.0, mcrfpy.Easing.LINEAR)
# Advance simulation synchronously
mcrfpy.step(1.5)
# Verify results
if abs(frame.x - 500.0) < 0.1:
print("PASS")
sys.exit(0)
else:
print(f"FAIL: frame.x = {frame.x}, expected 500.0")
sys.exit(1)
Test Pattern: Timer-based (legacy)
For tests that need multiple timer callbacks or complex timing:
import mcrfpy
import sys
def run_test(runtime):
# Test code here
print("PASS")
sys.exit(0)
scene = mcrfpy.Scene("test")
scene.activate()
# Timer fires after 100ms
timer = mcrfpy.Timer("test", run_test, 100)
# Script ends, game loop runs timer
Test Output
- Print
PASSandsys.exit(0)for success - Print
FAILwith details andsys.exit(1)for failure - Tests that timeout are marked as failures
Test Categories
Unit Tests (unit/)
Test individual components in isolation:
*_test.py- Standard component testsapi_*_test.py- Python API testsautomation_*_test.py- Automation module tests
Regression Tests (regression/)
Tests for specific bug fixes, named by issue number:
issue_XX_description_test.py
Integration Tests (integration/)
Tests for system interactions and complex scenarios.
Benchmarks (benchmarks/)
Performance measurement tests.
Demo (demo/)
Interactive demonstrations of features. Run with:
cd build
./mcrogueface ../tests/demo/demo_main.py
Tips
- Read tests as examples: Tests show correct API usage
- Use
mcrfpy.step(): Avoids timeout issues, makes tests deterministic - Check KNOWN_ISSUES.md: Documents expected failures and workarounds
- Screenshots: Use
mcrfpy.automation.screenshot("name.png")aftermcrfpy.step()
See Also
KNOWN_ISSUES.md- Current test status and themcrfpy.step()patternconftest.py- Pytest fixtures and custom collectordemo/screens/- Feature demonstrations (good API examples)