john/McRogueFace
1
0
Fork 0
Code Issues 26 Pull requests Projects Releases Wiki Activity

[Tiny Feature] Re-enable ASan leak detection after fixing #266/#275 #286

New issue
Closed
opened 2026-03-08 03:20:15 +00:00 by john · 0 comments
john commented 2026-03-08 03:20:15 +00:00
Owner
Copy link

Context

The ASan test suite currently runs with detect_leaks=0 because CPython has intentional lifetime leaks (interned strings, type objects, small int cache) that flood LeakSanitizer output. However, this also suppresses detection of real leaks like #266 (UIEntity self-reference cycle) and #275 (unbalanced Py_INCREF in entity init).

Proposal

After fixing #266 and #275:

  1. Re-enable detect_leaks=1 in ASAN_OPTIONS
  2. Add LSAN suppressions for known CPython intentional leaks (already in sanitizers/asan.supp)
  3. Validate that real McRogueFace leaks are detected while CPython noise is suppressed

Related

  • #266 (UIEntity self-reference cycle leak)
  • #275 (UIEntity unbalanced Py_INCREF)
  • #279 (memory safety audit meta-issue)
## Context The ASan test suite currently runs with `detect_leaks=0` because CPython has intentional lifetime leaks (interned strings, type objects, small int cache) that flood LeakSanitizer output. However, this also suppresses detection of real leaks like #266 (UIEntity self-reference cycle) and #275 (unbalanced Py_INCREF in entity init). ## Proposal After fixing #266 and #275: 1. Re-enable `detect_leaks=1` in `ASAN_OPTIONS` 2. Add LSAN suppressions for known CPython intentional leaks (already in `sanitizers/asan.supp`) 3. Validate that real McRogueFace leaks are detected while CPython noise is suppressed ## Related - #266 (UIEntity self-reference cycle leak) - #275 (UIEntity unbalanced Py_INCREF) - #279 (memory safety audit meta-issue)
john closed this issue 2026-04-10 05:09:19 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
threedee
emscripten-mcrogueface
rogueliketutorial25
alpha_presentable
alpha_streamline_2
alpha_streamline_1
interpreter_mode
grid_entity_integration
reprs_and_member_names
break_up_ui_h
standardize_font_handling
standardize_vector_handling
standardize_color_handling
standardize_texture_handling
raii_pyobjects
rebase-for-7DRL_Feb-2024
engjam_uicollection
engjam_ui_overhaul
0.2.3-prerelease-7drl2026-emscripten
Labels
Clear labels   
Alpha Release Requirement

This issue is a blocker to 0.1 Alpha release of McRogueFace.

  
Bugfix

   
Demo Target

Functionality to demonstrate; Depends on new features, but this issue isn't for writing them.

  
Documentation

   
Major Feature

Significant time and effort required.

  
Minor Feature

Some effort required to create or overhaul functionality.

  
priority:tier1-active

Current development focus - critical path to v1.0

  
priority:tier2-foundation

Important foundation work - not blocking v1.0

  
priority:tier3-future

Future features - deferred until after v1.0

  
priority:tier4-deferred

   
Refactoring & Cleanup

no new functionality, just improving the codebase.

  
system:animation

Animation and property interpolation

  
system:documentation

Documentation infrastructure

  
system:grid

Grid system and spatial containers

  
system:input

Input handling and events

  
system:performance

Performance optimization and profiling

  
system:procgen

Procedural Generation (Noise, BSP, Heightmap)

  
system:python-binding

Python/C++ binding layer

  
system:rendering

Rendering pipeline and visuals

  
system:ui-hierarchy

UI component hierarchy and composition

  
Tiny Feature

quick and easy - a few lines or with little interconnection around the codebase

  
workflow:blocked

Blocked by other work - waiting on dependencies

  
workflow:needs-benchmark

Needs performance testing and benchmarks

  
workflow:needs-documentation

Needs documentation before or after implementation

No labels
Alpha Release Requirement
Bugfix
Demo Target
Documentation
Major Feature
Minor Feature
priority:tier1-active
priority:tier2-foundation
priority:tier3-future
priority:tier4-deferred
Refactoring & Cleanup
system:animation
system:documentation
system:grid
system:input
system:performance
system:procgen
system:python-binding
system:rendering
system:ui-hierarchy
Tiny Feature
workflow:blocked
workflow:needs-benchmark
workflow:needs-documentation
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
john/McRogueFace#286
No description provided.