john/McRogueFace

Fork 0

Animation Property Locking #120

New issue

Closed

opened 2025-07-12 19:06:28 +00:00 by john · 1 comment

john commented

2025-07-12 19:06:28 +00:00

Owner

Prevent multiple animations from conflicting on the same property.
Definition of Done:

Only one animation per property at a time
Later animations either queue or override (configurable)
No visual glitches from conflicting animations
Clear error messages for conflicts

Prevent multiple animations from conflicting on the same property. Definition of Done: - Only one animation per property at a time - Later animations either queue or override (configurable) - No visual glitches from conflicting animations - Clear error messages for conflicts

john added the

Bugfix

Minor Feature

labels

2025-07-12 19:06:28 +00:00

john referenced this issue from a commit

2025-07-14 05:39:08 +00:00

Update ROADMAP with GitHub issue numbers (#111-#125)

john referenced this issue from a commit

2025-07-16 01:42:02 +00:00

Squashed commit of the following: [alpha_presentable]

john added the

Refactoring & Cleanup

system:ui-hierarchy

workflow:needs-documentation

priority:tier1-active

system:animation

workflow:blocked

labels

2025-10-26 00:44:38 +00:00

john added this to the Cursor, Grid, and Callback project

2025-11-27 13:26:05 +00:00

john removed the

workflow:blocked

label

2025-12-28 17:37:16 +00:00

john commented

2025-12-28 18:22:06 +00:00

Author

Owner

Implementation Complete (commit `58efffd`)

Animation property locking is now implemented with three conflict modes:

API

anim = mcrfpy.Animation("x", 500.0, 2.0, "linear")

# Default behavior - replace existing animation
anim.start(frame)

# Explicitly specify conflict mode
anim.start(frame, conflict_mode="replace")  # Complete old, start new
anim.start(frame, conflict_mode="queue")    # Wait for existing to complete
anim.start(frame, conflict_mode="error")    # Raise RuntimeError if busy

Behavior

Mode	When Property Busy	Effect
`replace`	Old animation jumps to final value	New animation starts immediately
`queue`	New animation is queued	Starts automatically when property freed
`error`	RuntimeError raised	No change to existing animation

Technical Details

Property locks tracked per (target_ptr, property_name) pair
Locks automatically cleaned up when animations complete or targets destroyed
Queue processed after each animation manager update
Different properties on same target can animate simultaneously
Same property on different targets can animate simultaneously

Test Coverage

Added tests/unit/test_animation_property_locking.py with 8 tests covering:

Replace mode (default and explicit)
Queue mode
Error mode with proper exception
Invalid conflict_mode validation
Different properties (no conflict)
Different targets (no conflict)
Replace mode completing old animation value

## Implementation Complete (commit 58efffd) Animation property locking is now implemented with three conflict modes: ### API ```python anim = mcrfpy.Animation("x", 500.0, 2.0, "linear") # Default behavior - replace existing animation anim.start(frame) # Explicitly specify conflict mode anim.start(frame, conflict_mode="replace") # Complete old, start new anim.start(frame, conflict_mode="queue") # Wait for existing to complete anim.start(frame, conflict_mode="error") # Raise RuntimeError if busy ``` ### Behavior | Mode | When Property Busy | Effect | |------|-------------------|--------| | `replace` | Old animation jumps to final value | New animation starts immediately | | `queue` | New animation is queued | Starts automatically when property freed | | `error` | RuntimeError raised | No change to existing animation | ### Technical Details - Property locks tracked per `(target_ptr, property_name)` pair - Locks automatically cleaned up when animations complete or targets destroyed - Queue processed after each animation manager update - Different properties on same target can animate simultaneously - Same property on different targets can animate simultaneously ### Test Coverage Added `tests/unit/test_animation_property_locking.py` with 8 tests covering: - Replace mode (default and explicit) - Queue mode - Error mode with proper exception - Invalid conflict_mode validation - Different properties (no conflict) - Different targets (no conflict) - Replace mode completing old animation value

john referenced this issue from a commit

2025-12-28 18:23:44 +00:00

feat: Animation property locking prevents conflicting animations (closes #120)

john closed this issue

2025-12-28 18:23:44 +00:00

john referenced this issue

2025-12-28 18:53:03 +00:00

Grid Point Animation #124