john/McRogueFace
1
0
Fork 0
Code Issues 42 Pull requests Projects 1 Releases Wiki Activity

clean up COMP4300 style #44

New issue
Closed
opened 2024-03-09 19:42:16 +00:00 by john · 1 comment
john commented 2024-03-09 19:42:16 +00:00
Owner
Copy link

61 refactor: clean up COMP4300 style and remove "e" / "c" / "s" prefixes on GameEngine / Scene methods

61 refactor: clean up COMP4300 style and remove "e" / "c" / "s" prefixes on GameEngine / Scene methods
john commented 2024-04-20 17:43:01 +00:00
Author
Owner
Copy link

Should be a quick fix: all the ECS specific stuff has already been removed, so "sRender" is the only remaining vestige.

$ grep "sRender" *
GameEngine.cpp:        currentScene()->sRender();
PyScene.cpp:void PyScene::sRender()
PyScene.h:    void sRender() override final;
Scene.h:    virtual void sRender() = 0;
grep: scripts: Is a directory
UITestScene.cpp:void UITestScene::sRender()
UITestScene.h:    void sRender() override final;
Should be a quick fix: all the ECS specific stuff has already been removed, so "sRender" is the only remaining vestige. ``` $ grep "sRender" * GameEngine.cpp: currentScene()->sRender(); PyScene.cpp:void PyScene::sRender() PyScene.h: void sRender() override final; Scene.h: virtual void sRender() = 0; grep: scripts: Is a directory UITestScene.cpp:void UITestScene::sRender() UITestScene.h: void sRender() override final; ```
john closed this issue 2024-04-20 18:16:56 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
rogueliketutorial25
alpha_presentable
alpha_streamline_2
alpha_streamline_1
interpreter_mode
grid_entity_integration
reprs_and_member_names
break_up_ui_h
standardize_font_handling
standardize_vector_handling
standardize_color_handling
standardize_texture_handling
raii_pyobjects
rebase-for-7DRL_Feb-2024
engjam_uicollection
engjam_ui_overhaul
No results found.
Labels
Clear labels   
Alpha Release Requirement

This issue is a blocker to 0.1 Alpha release of McRogueFace.

  
Bugfix

   
Demo Target

Functionality to demonstrate; Depends on new features, but this issue isn't for writing them.

  
Documentation

   
Major Feature

Significant time and effort required.

  
Minor Feature

Some effort required to create or overhaul functionality.

  
priority:tier1-active

Current development focus - critical path to v1.0

  
priority:tier2-foundation

Important foundation work - not blocking v1.0

  
priority:tier3-future

Future features - deferred until after v1.0

  
priority:tier4-deferred

   
Refactoring & Cleanup

no new functionality, just improving the codebase.

  
system:animation

Animation and property interpolation

  
system:documentation

Documentation infrastructure

  
system:grid

Grid system and spatial containers

  
system:input

Input handling and events

  
system:performance

Performance optimization and profiling

  
system:procgen

Procedural Generation (Noise, BSP, Heightmap)

  
system:python-binding

Python/C++ binding layer

  
system:rendering

Rendering pipeline and visuals

  
system:ui-hierarchy

UI component hierarchy and composition

  
Tiny Feature

quick and easy - a few lines or with little interconnection around the codebase

  
workflow:blocked

Blocked by other work - waiting on dependencies

  
workflow:needs-benchmark

Needs performance testing and benchmarks

  
workflow:needs-documentation

Needs documentation before or after implementation

No labels
Alpha Release Requirement
Bugfix
Demo Target
Documentation
Major Feature
Minor Feature
priority:tier1-active
priority:tier2-foundation
priority:tier3-future
priority:tier4-deferred
Refactoring & Cleanup
system:animation
system:documentation
system:grid
system:input
system:performance
system:procgen
system:python-binding
system:rendering
system:ui-hierarchy
Tiny Feature
workflow:blocked
workflow:needs-benchmark
workflow:needs-documentation
Milestone
Clear milestone
No items
Projects
Clear projects
No items
No project
The Datatype Overhaul
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
john/McRogueFace#44
No description provided.