GridView.texture getter always returns None (unimplemented) #318

Closed
opened 2026-06-21 10:37:07 +00:00 by john · 0 comments
Owner

Found during the #314 F15 docstring-accuracy verify pass.

In src/UIGridView.cpp, the texture getter returns Py_RETURN_NONE unconditionally — even when self->data->ptex is non-null, the code falls through a TODO and never constructs/returns a Texture. So GridView.texture is effectively always None.

Impact: Users cannot read the tile texture from a GridView. Either implement the Texture return path, or formally drop the property.

The docstring has been updated (in the F15 accuracy pass) to read (None, read-only) with a note that the Texture return is not yet implemented; this issue tracks the implementation.

Suggested labels: Bugfix, system:rendering, system:grid, priority:tier3-future. (Apply manually — Gitea MCP label bug.)

Refs #314

Found during the #314 F15 docstring-accuracy verify pass. In `src/UIGridView.cpp`, the `texture` getter returns `Py_RETURN_NONE` unconditionally — even when `self->data->ptex` is non-null, the code falls through a `TODO` and never constructs/returns a Texture. So `GridView.texture` is effectively always `None`. **Impact:** Users cannot read the tile texture from a `GridView`. Either implement the Texture return path, or formally drop the property. The docstring has been updated (in the F15 accuracy pass) to read `(None, read-only)` with a note that the Texture return is not yet implemented; this issue tracks the implementation. Suggested labels: `Bugfix`, `system:rendering`, `system:grid`, `priority:tier3-future`. (Apply manually — Gitea MCP label bug.) Refs #314
john closed this issue 2026-06-21 14:12:50 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
john/McRogueFace#318
No description provided.