[Bugfix] automation.scroll() ignores the x-coordinate of its position argument #317

Closed
opened 2026-06-21 10:37:03 +00:00 by john · 0 comments
Owner

Found during the #314 F15 docstring-accuracy verify pass.

In src/McRFPy_Automation.cpp, scroll(clicks, pos=None) resolves a position via PyPosition_ParseInt but the call to injectMouseEvent(sf::Event::MouseWheelScrolled, clicks, y) passes clicks as the x argument and y as the y argument — the resolved x coordinate of pos is never used. So scrolling "at a position" only honors the y of that position.

Impact: automation.scroll(n, pos=(x, y)) behaves as if x were ignored. Either the x should be forwarded to the injected event, or the API should not accept an x at all.

The docstring has been updated (in the F15 accuracy pass) to note that x is currently ignored; this issue tracks the underlying code fix.

Suggested labels: Bugfix, system:input, priority:tier3-future. (Apply manually — Gitea MCP label bug.)

Refs #314

Found during the #314 F15 docstring-accuracy verify pass. In `src/McRFPy_Automation.cpp`, `scroll(clicks, pos=None)` resolves a position via `PyPosition_ParseInt` but the call to `injectMouseEvent(sf::Event::MouseWheelScrolled, clicks, y)` passes `clicks` as the x argument and `y` as the y argument — the resolved **x coordinate of `pos` is never used**. So scrolling "at a position" only honors the y of that position. **Impact:** `automation.scroll(n, pos=(x, y))` behaves as if x were ignored. Either the x should be forwarded to the injected event, or the API should not accept an x at all. The docstring has been updated (in the F15 accuracy pass) to note that x is currently ignored; this issue tracks the underlying code fix. Suggested labels: `Bugfix`, `system:input`, `priority:tier3-future`. (Apply manually — Gitea MCP label bug.) Refs #314
john closed this issue 2026-06-21 14:12:50 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
john/McRogueFace#317
No description provided.