john/McRogueFace
1
0
Fork 0
Code Issues 42 Pull requests Projects 1 Releases Wiki Activity

implement __hash__ in a way that preserves C++ object identity #29

New issue
Closed
opened 2024-03-09 19:01:55 +00:00 by john · 1 comment
john commented 2024-03-09 19:01:55 +00:00
Owner
Copy link

Notes say:
34 feat: All python objects that wrap C++ classes should return the "data" pointer address as a hash, so that "is" operator will work on UI objects or collections generated as different Python objects

  • PyUIDrawable derived class implementations pretty universally use data as a std::shared_ptr<UIDerivedSomethingOrOther>. The actual pointer address inside that shared pointer is the object, and it's how live changes are made.
  • But the PyTYPE_HEAD or whatever holds the Python object info can be duplicated - multiple Python objects can hold shared pointers to the same C++ object. Totally intentional.
  • If Python objects point to the same C++ object, a is b should return True.
Notes say: 34 feat: All python objects that wrap C++ classes should return the "data" pointer address as a hash, so that "is" operator will work on UI objects or collections generated as different Python objects * PyUIDrawable derived class implementations pretty universally use `data` as a `std::shared_ptr<UIDerivedSomethingOrOther>`. The actual pointer address inside that shared pointer *is* the object, and it's how live changes are made. * But the `PyTYPE_HEAD` or whatever holds the Python object info can be duplicated - multiple Python objects can hold shared pointers to the same C++ object. Totally intentional. * If Python objects point to the same C++ object, `a is b` should return `True`.
john commented 2024-04-20 18:23:16 +00:00
Author
Owner
Copy link

wontfix / the current usage of hash is probably incorrect and should be deprecated. Hashable object should be immutable. So the mcrf data containers probably should not have this value.

wontfix / the current usage of hash is probably incorrect and should be deprecated. Hashable object should be immutable. So the mcrf data containers probably should not have this value.
john closed this issue 2024-04-20 18:23:16 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
rogueliketutorial25
alpha_presentable
alpha_streamline_2
alpha_streamline_1
interpreter_mode
grid_entity_integration
reprs_and_member_names
break_up_ui_h
standardize_font_handling
standardize_vector_handling
standardize_color_handling
standardize_texture_handling
raii_pyobjects
rebase-for-7DRL_Feb-2024
engjam_uicollection
engjam_ui_overhaul
No results found.
Labels
Clear labels   
Alpha Release Requirement

This issue is a blocker to 0.1 Alpha release of McRogueFace.

  
Bugfix

   
Demo Target

Functionality to demonstrate; Depends on new features, but this issue isn't for writing them.

  
Documentation

   
Major Feature

Significant time and effort required.

  
Minor Feature

Some effort required to create or overhaul functionality.

  
priority:tier1-active

Current development focus - critical path to v1.0

  
priority:tier2-foundation

Important foundation work - not blocking v1.0

  
priority:tier3-future

Future features - deferred until after v1.0

  
priority:tier4-deferred

   
Refactoring & Cleanup

no new functionality, just improving the codebase.

  
system:animation

Animation and property interpolation

  
system:documentation

Documentation infrastructure

  
system:grid

Grid system and spatial containers

  
system:input

Input handling and events

  
system:performance

Performance optimization and profiling

  
system:procgen

Procedural Generation (Noise, BSP, Heightmap)

  
system:python-binding

Python/C++ binding layer

  
system:rendering

Rendering pipeline and visuals

  
system:ui-hierarchy

UI component hierarchy and composition

  
Tiny Feature

quick and easy - a few lines or with little interconnection around the codebase

  
workflow:blocked

Blocked by other work - waiting on dependencies

  
workflow:needs-benchmark

Needs performance testing and benchmarks

  
workflow:needs-documentation

Needs documentation before or after implementation

No labels
Alpha Release Requirement
Bugfix
Demo Target
Documentation
Major Feature
Minor Feature
priority:tier1-active
priority:tier2-foundation
priority:tier3-future
priority:tier4-deferred
Refactoring & Cleanup
system:animation
system:documentation
system:grid
system:input
system:performance
system:procgen
system:python-binding
system:rendering
system:ui-hierarchy
Tiny Feature
workflow:blocked
workflow:needs-benchmark
workflow:needs-documentation
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Fun, Convenient McRogueFace Objects
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
john/McRogueFace#29
No description provided.