john/McRogueFace
1
0
Fork 0
Code Issues 42 Pull requests Projects 1 Releases Wiki Activity

UIGrid: replace vector member getter/setters #20

New issue
Closed
opened 2024-03-09 18:54:41 +00:00 by john · 2 comments
john commented 2024-03-09 18:54:41 +00:00
Owner
Copy link

Notes say:
25 refactor: UIGrid get_grid_size replaced with standardized vector methods [depend on feat: standardize vector handling]

Notes say: 25 refactor: UIGrid get_grid_size replaced with standardized vector methods \[depend on feat: standardize vector handling]
john removed this from the The Datatype Overhaul project 2024-03-13 13:12:16 +00:00
john commented 2025-11-26 10:12:12 +00:00
Author
Owner
Copy link

Status: Partially addressed, no longer actionable

  • grid_size exists as read-only property returning (grid_x, grid_y) tuple (src/UIGrid.cpp:810-812, 1462)
  • grid_x and grid_y also available as read-only properties
  • No setter is appropriate - resizing a grid would invalidate:
    • The TCOD map
    • All entity gridstate vectors
    • The points vector
    • The render texture

The original note mentioned "depend on feat: standardize vector handling" - the current tuple-based getter IS the standardized approach.

Status: Partially addressed, no longer actionable - grid_size exists as read-only property returning (grid_x, grid_y) tuple (src/UIGrid.cpp:810-812, 1462) - grid_x and grid_y also available as read-only properties - No setter is appropriate - resizing a grid would invalidate: - The TCOD map - All entity gridstate vectors - The points vector - The render texture The original note mentioned "depend on feat: standardize vector handling" - the current tuple-based getter IS the standardized approach.
john closed this issue 2025-11-26 10:12:12 +00:00
john commented 2025-11-26 10:23:51 +00:00
Author
Owner
Copy link

Complete - Read-Only is Correct

The grid_size property exists as a read-only getter returning (grid_x, grid_y) tuple.

Current API

grid.grid_size  # Returns (grid_x, grid_y) tuple
grid.grid_x     # Individual dimension
grid.grid_y     # Individual dimension

A setter is intentionally not provided because resizing a grid would invalidate:

  • The TCOD map for FOV/pathfinding
  • All entity gridstate vectors
  • The internal points vector
  • The render texture

If grid resizing is needed, the correct approach is to create a new grid. The original note mentioned "depend on feat: standardize vector handling" - the current tuple-based getter IS the standardized approach used throughout the codebase.

## Complete - Read-Only is Correct The `grid_size` property exists as a read-only getter returning `(grid_x, grid_y)` tuple. ### Current API ```python grid.grid_size # Returns (grid_x, grid_y) tuple grid.grid_x # Individual dimension grid.grid_y # Individual dimension ``` A **setter is intentionally not provided** because resizing a grid would invalidate: - The TCOD map for FOV/pathfinding - All entity gridstate vectors - The internal points vector - The render texture If grid resizing is needed, the correct approach is to create a new grid. The original note mentioned "depend on feat: standardize vector handling" - the current tuple-based getter IS the standardized approach used throughout the codebase.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
rogueliketutorial25
alpha_presentable
alpha_streamline_2
alpha_streamline_1
interpreter_mode
grid_entity_integration
reprs_and_member_names
break_up_ui_h
standardize_font_handling
standardize_vector_handling
standardize_color_handling
standardize_texture_handling
raii_pyobjects
rebase-for-7DRL_Feb-2024
engjam_uicollection
engjam_ui_overhaul
No results found.
Labels
Clear labels   
Alpha Release Requirement

This issue is a blocker to 0.1 Alpha release of McRogueFace.

  
Bugfix

   
Demo Target

Functionality to demonstrate; Depends on new features, but this issue isn't for writing them.

  
Documentation

   
Major Feature

Significant time and effort required.

  
Minor Feature

Some effort required to create or overhaul functionality.

  
priority:tier1-active

Current development focus - critical path to v1.0

  
priority:tier2-foundation

Important foundation work - not blocking v1.0

  
priority:tier3-future

Future features - deferred until after v1.0

  
priority:tier4-deferred

   
Refactoring & Cleanup

no new functionality, just improving the codebase.

  
system:animation

Animation and property interpolation

  
system:documentation

Documentation infrastructure

  
system:grid

Grid system and spatial containers

  
system:input

Input handling and events

  
system:performance

Performance optimization and profiling

  
system:procgen

Procedural Generation (Noise, BSP, Heightmap)

  
system:python-binding

Python/C++ binding layer

  
system:rendering

Rendering pipeline and visuals

  
system:ui-hierarchy

UI component hierarchy and composition

  
Tiny Feature

quick and easy - a few lines or with little interconnection around the codebase

  
workflow:blocked

Blocked by other work - waiting on dependencies

  
workflow:needs-benchmark

Needs performance testing and benchmarks

  
workflow:needs-documentation

Needs documentation before or after implementation

No labels
Alpha Release Requirement
Bugfix
Demo Target
Documentation
Major Feature
Minor Feature
priority:tier1-active
priority:tier2-foundation
priority:tier3-future
priority:tier4-deferred
Refactoring & Cleanup
system:animation
system:documentation
system:grid
system:input
system:performance
system:procgen
system:python-binding
system:rendering
system:ui-hierarchy
Tiny Feature
workflow:blocked
workflow:needs-benchmark
workflow:needs-documentation
Milestone
Clear milestone
No items
Projects
Clear projects
No items
No project
Fun, Convenient McRogueFace Objects
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
john/McRogueFace#20
No description provided.