john/McRogueFace
1
0
Fork 0
Code Issues 28 Pull requests Projects Releases Wiki Activity

Remove deprecated sprite_number property from Sprite and Entity, closes #305

Browse source 
sprite_number was a legacy alias for sprite_index. All code should use
sprite_index directly. Removed from getsetters, setProperty/getProperty/
hasProperty in UISprite and UIEntity, animation property handling, and
type stubs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
John McCardle 2026-04-09 22:18:20 -04:00
commit c15d836e79
9 changed files with 20 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

16
tests/unit/ui_Sprite_issue19_test.py
View file

@ -38,21 +38,21 @@ except AttributeError:
except Exception as e:
print(f"✗ Unexpected error setting texture: {e}")
# Test sprite_number property
# Test sprite_index property
try:
print(f"Sprite2 sprite_number: {sprite2.sprite_number}")
sprite2.sprite_number = 10
print(f"✓ Changed sprite_number to: {sprite2.sprite_number}")
print(f"Sprite2 sprite_index: {sprite2.sprite_index}")
sprite2.sprite_index = 10
print(f"sprite_index set to: {sprite2.sprite_index}")
except Exception as e:
print(f"✗ sprite_number property failed: {e}")
print(f"sprite_index property failed: {e}")
# Test sprite index validation (Issue #33)
try:
# Try to set invalid sprite index
sprite2.sprite_number = 9999
print("✗ Should validate sprite index against texture range (Issue #33)")
sprite2.sprite_index = 9999
print("Should validate sprite index against texture range (Issue #33)")
except Exception as e:
print(f"✓ Sprite index validation works: {e}")
print(f"Sprite index validation works: {e}")
# Create grid of sprites to show different indices
y_offset = 100