john/McRogueFace
1
0
Fork 0
Code Issues 26 Pull requests Projects Releases Wiki Activity

Remove deprecated sprite_number property from Sprite and Entity, closes #305

Browse source 
sprite_number was a legacy alias for sprite_index. All code should use
sprite_index directly. Removed from getsetters, setProperty/getProperty/
hasProperty in UISprite and UIEntity, animation property handling, and
type stubs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
John McCardle 2026-04-09 22:18:20 -04:00
commit c15d836e79
9 changed files with 20 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/unit/ui_Entity_issue73_test.py
View file

@ -35,11 +35,11 @@ def test_Entity():
try:
print(f" Entity1 pos: {entity1.pos}")
print(f" Entity1 draw_pos: {entity1.draw_pos}")
print(f" Entity1 sprite_number: {entity1.sprite_number}")
print(f" Entity1 sprite_index: {entity1.sprite_index}")
# Modify properties
entity1.pos = mcrfpy.Vector(3, 3)
entity1.sprite_number = 5
entity1.sprite_index = 5
print(" Entity properties modified")
except Exception as e:
print(f"X Entity property access failed: {e}")

16
tests/unit/ui_Sprite_issue19_test.py
View file

@ -38,21 +38,21 @@ except AttributeError:
except Exception as e:
print(f"✗ Unexpected error setting texture: {e}")
# Test sprite_number property
# Test sprite_index property
try:
print(f"Sprite2 sprite_number: {sprite2.sprite_number}")
sprite2.sprite_number = 10
print(f"✓ Changed sprite_number to: {sprite2.sprite_number}")
print(f"Sprite2 sprite_index: {sprite2.sprite_index}")
sprite2.sprite_index = 10
print(f"sprite_index set to: {sprite2.sprite_index}")
except Exception as e:
print(f"✗ sprite_number property failed: {e}")
print(f"sprite_index property failed: {e}")
# Test sprite index validation (Issue #33)
try:
# Try to set invalid sprite index
sprite2.sprite_number = 9999
print("✗ Should validate sprite index against texture range (Issue #33)")
sprite2.sprite_index = 9999
print("Should validate sprite index against texture range (Issue #33)")
except Exception as e:
print(f"✓ Sprite index validation works: {e}")
print(f"Sprite index validation works: {e}")
# Create grid of sprites to show different indices
y_offset = 100