john/McRogueFace
1
0
Fork 0
Code Issues 26 Pull requests Projects Releases Wiki Activity

Add texture display bounds for non-uniform sprite content, closes #235

Browse source 
Textures can now specify display_size and display_origin to crop sprite
rendering to a sub-region within each atlas cell. This supports texture
atlases where content doesn't fill the entire cell (e.g., 16x24 sprites
centered in 32x32 cells).

API: Texture("sprites.png", 32, 32, display_size=(16, 24), display_origin=(8, 4))
Properties: display_width, display_height, display_offset_x, display_offset_y

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
John McCardle 2026-04-10 02:57:41 -04:00
commit 9a06ae5d8e
3 changed files with 146 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/PyTexture.h
View file

@ -17,10 +17,14 @@ private:
int sheet_width, sheet_height;
// Private default constructor for factory methods
PyTexture() : source("<uninitialized>"), sprite_width(0), sprite_height(0), sheet_width(0), sheet_height(0) {}
PyTexture() : source("<uninitialized>"), sprite_width(0), sprite_height(0), sheet_width(0), sheet_height(0),
display_width(-1), display_height(-1), display_offset_x(0), display_offset_y(0) {}
public:
int sprite_width, sprite_height; // just use them read only, OK?
// #235: Display bounds for non-uniform sprite content within cells
int display_width, display_height; // -1 = same as sprite_width/height
int display_offset_x, display_offset_y; // offset within cell to content area
PyTexture(std::string filename, int sprite_w, int sprite_h);
// #144: Factory method to create texture from rendered content (snapshot)
@ -42,6 +46,10 @@ public:
static int init(PyTextureObject*, PyObject*, PyObject*);
static PyObject* pynew(PyTypeObject* type, PyObject* args=NULL, PyObject* kwds=NULL);
// Effective display dimensions (resolves -1 defaults)
int getDisplayWidth() const { return display_width >= 0 ? display_width : sprite_width; }
int getDisplayHeight() const { return display_height >= 0 ? display_height : sprite_height; }
// Getters for properties
static PyObject* get_sprite_width(PyTextureObject* self, void* closure);
static PyObject* get_sprite_height(PyTextureObject* self, void* closure);
@ -49,6 +57,10 @@ public:
static PyObject* get_sheet_height(PyTextureObject* self, void* closure);
static PyObject* get_sprite_count(PyTextureObject* self, void* closure);
static PyObject* get_source(PyTextureObject* self, void* closure);
static PyObject* get_display_width(PyTextureObject* self, void* closure);
static PyObject* get_display_height(PyTextureObject* self, void* closure);
static PyObject* get_display_offset_x(PyTextureObject* self, void* closure);
static PyObject* get_display_offset_y(PyTextureObject* self, void* closure);
static PyGetSetDef getsetters[];
@ -69,17 +81,22 @@ namespace mcrfpydef {
.tp_hash = PyTexture::hash,
.tp_flags = Py_TPFLAGS_DEFAULT,
.tp_doc = PyDoc_STR(
"Texture(filename: str, sprite_width: int = 0, sprite_height: int = 0)\n\n"
"Texture(filename: str, sprite_width: int = 0, sprite_height: int = 0, "
"display_size: tuple = None, display_origin: tuple = None)\n\n"
"A texture atlas for sprites and tiles.\n\n"
"Args:\n"
" filename: Path to an image file (PNG, BMP, etc.).\n"
" sprite_width: Width of each sprite cell in pixels (0 = full image).\n"
" sprite_height: Height of each sprite cell in pixels (0 = full image).\n\n"
" sprite_height: Height of each sprite cell in pixels (0 = full image).\n"
" display_size: Optional (w, h) actual content size within each cell.\n"
" display_origin: Optional (x, y) content offset within each cell.\n\n"
"Properties:\n"
" sprite_width, sprite_height (int, read-only): Cell dimensions.\n"
" sheet_width, sheet_height (int, read-only): Grid dimensions in cells.\n"
" sprite_count (int, read-only): Total number of sprite cells.\n"
" source (str, read-only): File path used to load this texture.\n"
" display_width, display_height (int, read-only): Content size within cells.\n"
" display_offset_x, display_offset_y (int, read-only): Content offset within cells.\n"
),
.tp_getset = PyTexture::getsetters,
//.tp_base = &PyBaseObject_Type,