john/McRogueFace
1
0
Fork 0
Code Issues 26 Pull requests Projects Releases Wiki Activity

Remove legacy string enum comparisons from InputState/Key/MouseButton, closes #306

Browse source 
Removed custom __eq__/__ne__ that allowed comparing enums to legacy string
names (e.g., Key.ESCAPE == "Escape"). Removed _legacy_names dicts and
to_legacy_string() functions. Kept from_legacy_string() in PyKey.cpp as
it's used by C++ event dispatch. Updated ~50 Python test/demo/cookbook
files to use enum members instead of string comparisons. Also updates
grid.position -> grid.pos in files that had both types of changes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
John McCardle 2026-04-09 22:19:02 -04:00
commit 6d5e99a114
52 changed files with 372 additions and 533 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/docs/test_quickstart_entities.py
View file

@ -46,15 +46,15 @@ grid.entities.append(treasure)
# Movement handler using modern API
def handle_keys(key, state):
if state == "start":
if state == mcrfpy.InputState.PRESSED:
x, y = player.pos[0], player.pos[1]
if key == "W":
if key == mcrfpy.Key.W:
player.pos = (x, y - 1)
elif key == "S":
elif key == mcrfpy.Key.S:
player.pos = (x, y + 1)
elif key == "A":
elif key == mcrfpy.Key.A:
player.pos = (x - 1, y)
elif key == "D":
elif key == mcrfpy.Key.D:
player.pos = (x + 1, y)
scene.on_key = handle_keys