john/McRogueFace
1
0
Fork 0
Code Issues 32 Pull requests Projects Releases Wiki Activity

Simplify on_enter/on_exit callbacks to position-only signature

Browse source 
BREAKING CHANGE: Hover callbacks now take only (pos) instead of (pos, button, action)

- Add PyHoverCallable class for on_enter/on_exit/on_move callbacks (position-only)
- Add PyCellHoverCallable class for on_cell_enter/on_cell_exit callbacks
- Change UIDrawable member types from PyClickCallable to PyHoverCallable
- Update PyScene::do_mouse_hover() to call hover callbacks with only position
- Add tryCallPythonMethod overload for position-only subclass method calls
- Update UIGrid::fireCellEnter/fireCellExit to use position-only signature
- Update all tests for new callback signatures

New callback signatures:
| Callback       | Old                      | New        |
|----------------|--------------------------|------------|
| on_enter       | (pos, button, action)    | (pos)      |
| on_exit        | (pos, button, action)    | (pos)      |
| on_move        | (pos, button, action)    | (pos)      |
| on_cell_enter  | (cell_pos, button, action)| (cell_pos)|
| on_cell_exit   | (cell_pos, button, action)| (cell_pos)|
| on_click       | unchanged                | unchanged  |
| on_cell_click  | unchanged                | unchanged  |

closes #230

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
John McCardle 2026-01-28 17:36:02 -05:00
commit 2daebc84b5
12 changed files with 598 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/unit/test_mouse_enter_exit.py
View file

@ -21,11 +21,11 @@ def test_callback_assignment():
frame = mcrfpy.Frame(pos=(100, 100), size=(200, 200))
ui.append(frame)
# Callbacks receive (x, y, button, action) - 4 arguments
def on_enter_cb(x, y, button, action):
# #230 - Hover callbacks now receive only (pos) - 1 argument
def on_enter_cb(pos):
pass
def on_exit_cb(x, y, button, action):
def on_exit_cb(pos):
pass
# Test assignment
@ -87,7 +87,8 @@ def test_all_types_have_events():
("Grid", mcrfpy.Grid(grid_size=(5, 5), pos=(0, 0), size=(100, 100))),
]
def dummy_cb(x, y, button, action):
# #230 - Hover callbacks now receive only (pos)
def dummy_cb(pos):
pass
for name, obj in types_to_test:
@ -129,15 +130,16 @@ def test_enter_exit_simulation():
frame = mcrfpy.Frame(pos=(100, 100), size=(200, 200))
ui.append(frame)
def on_enter(x, y, button, action):
# #230 - Hover callbacks now receive only (pos)
def on_enter(pos):
global enter_count, enter_positions
enter_count += 1
enter_positions.append((x, y))
enter_positions.append((pos.x, pos.y))
def on_exit(x, y, button, action):
def on_exit(pos):
global exit_count, exit_positions
exit_count += 1
exit_positions.append((x, y))
exit_positions.append((pos.x, pos.y))
frame.on_enter = on_enter
frame.on_exit = on_exit