john/McRogueFace
1
0
Fork 0
Code Issues 33 Pull requests Projects Releases Wiki Activity

Simplify on_enter/on_exit callbacks to position-only signature

Browse source 
BREAKING CHANGE: Hover callbacks now take only (pos) instead of (pos, button, action)

- Add PyHoverCallable class for on_enter/on_exit/on_move callbacks (position-only)
- Add PyCellHoverCallable class for on_cell_enter/on_cell_exit callbacks
- Change UIDrawable member types from PyClickCallable to PyHoverCallable
- Update PyScene::do_mouse_hover() to call hover callbacks with only position
- Add tryCallPythonMethod overload for position-only subclass method calls
- Update UIGrid::fireCellEnter/fireCellExit to use position-only signature
- Update all tests for new callback signatures

New callback signatures:
| Callback       | Old                      | New        |
|----------------|--------------------------|------------|
| on_enter       | (pos, button, action)    | (pos)      |
| on_exit        | (pos, button, action)    | (pos)      |
| on_move        | (pos, button, action)    | (pos)      |
| on_cell_enter  | (cell_pos, button, action)| (cell_pos)|
| on_cell_exit   | (cell_pos, button, action)| (cell_pos)|
| on_click       | unchanged                | unchanged  |
| on_cell_click  | unchanged                | unchanged  |

closes #230

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
John McCardle 2026-01-28 17:36:02 -05:00
commit 2daebc84b5
12 changed files with 598 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/UIDrawable.h
View file

@ -45,9 +45,9 @@ public:
// Mouse input handling - callable objects for click, enter, exit, move events
std::unique_ptr<PyClickCallable> click_callable;
std::unique_ptr<PyClickCallable> on_enter_callable; // #140
std::unique_ptr<PyClickCallable> on_exit_callable; // #140
std::unique_ptr<PyClickCallable> on_move_callable; // #141
std::unique_ptr<PyHoverCallable> on_enter_callable; // #140, #230 - position-only
std::unique_ptr<PyHoverCallable> on_exit_callable; // #140, #230 - position-only
std::unique_ptr<PyHoverCallable> on_move_callable; // #141, #230 - position-only
virtual UIDrawable* click_at(sf::Vector2f point) = 0;
void click_register(PyObject*);