John McCardle john
0 followers · 0 following

  • Site admin.

  • Joined on 2020-09-17
Repositories
7
 Projects Packages Public activity Starred repositories
john commented on issue john/McRogueFace#363 2026-07-13 02:09:59 +00:00
[Bugfix] Cursor leaving the window never fires on_cell_exit; hovered_cell stays stuck

The deferred LostFocus half is now filed as #367 — it reuses the do_mouse_leave() / dispatch_hover(pos, in_window) machinery this issue introduced, but carries a policy question this one…

john opened issue john/McRogueFace#367 2026-07-13 02:09:54 +00:00
[Bugfix] Losing window focus strands hover state the same way a window-leave did (#363's sibling)
john commented on issue john/McRogueFace#363 2026-07-13 01:13:25 +00:00
[Bugfix] Cursor leaving the window never fires on_cell_exit; hovered_cell stays stuck

Fixed on feat/355-grid-input-revival (4bb1966). Suite 325/325.

john pushed to at john/McRogueFace 2026-07-13 01:12:58 +00:00
4bb1966b97 fix(input): dispatch hover-exit when the cursor leaves the window
john commented on issue john/McRogueFace#365 2026-07-13 00:29:50 +00:00
[Bugfix] Stale last_clicked_cell can be dispatched for a GridView with no grid data

Fixed on feat/355-grid-input-revival (11f8394) — but the filed repro was wrong

john pushed to at john/McRogueFace 2026-07-13 00:27:28 +00:00
461dcf7f29 fix(grid): ~UIGridView unregisters from the GridData view registry
john commented on issue john/McRogueFace#361 2026-07-13 00:10:53 +00:00
[Refactor] Complete #252: GridData becomes a public data type, GridView is the only drawable, Grid becomes an alias

Correction to the design note above

john commented on issue john/McRogueFace#366 2026-07-13 00:10:38 +00:00
[Refactor] Dead derived_type()==UIGRID gate remains in UICollection::repr — grids counted as "other"

Correction to my previous comment — I was wrong about removeFromParent

john commented on issue john/McRogueFace#366 2026-07-13 00:10:15 +00:00
[Refactor] Dead derived_type()==UIGRID gate remains in UICollection::repr — grids counted as "other"

A third live instance found: UIDrawable::removeFromParent (2026-07-12)

john commented on issue john/McRogueFace#364 2026-07-13 00:10:00 +00:00
[Bugfix] Grid children's dirty propagation dead-ends at the internal UIGrid, never reaching the GridView or its caching ancestors

Correction: fix (a) is not available, and this is a #361 prerequisite (2026-07-12)

john commented on issue john/McRogueFace#361 2026-07-13 00:09:43 +00:00
[Refactor] Complete #252: GridData becomes a public data type, GridView is the only drawable, Grid becomes an alias

Design note: the parent problem, and why the split is right (2026-07-12)

john opened issue john/McRogueFace#366 2026-07-12 22:05:26 +00:00
[Refactor] Dead derived_type()==UIGRID gate remains in UICollection::repr — grids counted as "other"
john opened issue john/McRogueFace#365 2026-07-12 22:05:15 +00:00
[Bugfix] Stale last_clicked_cell can be dispatched for a GridView with no grid data
john opened issue john/McRogueFace#364 2026-07-12 22:05:04 +00:00
[Bugfix] Grid children's dirty propagation dead-ends at the internal UIGrid, never reaching the GridView or its caching ancestors
john opened issue john/McRogueFace#363 2026-07-12 22:04:50 +00:00
[Bugfix] Cursor leaving the window never fires on_cell_exit; hovered_cell stays stuck
john opened issue john/McRogueFace#362 2026-07-12 22:04:36 +00:00
[Bugfix] GridData::views leaks expired weak_ptrs — ~UIGridView never unregisters
john pushed to at john/McRogueFace 2026-07-12 22:02:29 +00:00
540c793e4e docs(grid): document grid-world child coordinates and the overlay pattern
john commented on issue john/McRogueFace#359 2026-07-12 20:59:26 +00:00
[Bugfix] Shared-data grid path is unwired: Grid(grid=...) never sets owning_view, and _GridData.view is always None

Resolution decided 2026-07-12: owning_view is deleted, not wired up. See #361, which now carries this.

john opened issue john/McRogueFace#361 2026-07-12 19:20:28 +00:00
[Refactor] Complete #252: _GridData (UIGrid) sheds UIDrawable — data is data, GridView is the only drawable
john opened issue john/McRogueFace#360 2026-07-12 19:20:04 +00:00
[Bugfix] Grid children get grid-world pixel coords in click_at, Frame children get frame-local — inconsistent